ribaraka commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1965042724
##########
cassandra_test.go:
##########
@@ -3256,6 +3256,10 @@ func TestCreateSession_DontSwallowError(t *testing.T) {
func TestControl_DiscoverProtocol(t *testing.T) {
cluster := createCluster()
cluster.ProtoVersion = 0
+ // Forcing to run this test without any compression.
+ // If compressor is presented, then CI will fail when snappy
compression is enabled, since
+ // protocol v5 doesn't support it.
+ cluster.Compressor = nil
Review Comment:
You've exluded the snappy from proto v5 in the CI, then everyting should
work fine. This block of code is likely unnecessary, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
