worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1960058558
##########
go.mod:
##########
@@ -18,13 +18,23 @@
module github.com/gocql/gocql
require (
- github.com/bitly/go-hostpool v0.0.0-20171023180738-a3a6125de932 //
indirect
- github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869 //
indirect
+ github.com/gocql/gocql/lz4 v0.0.0-00010101000000-000000000000
github.com/golang/snappy v0.0.3
github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed
- github.com/kr/pretty v0.1.0 // indirect
- github.com/stretchr/testify v1.3.0 // indirect
+ github.com/stretchr/testify v1.9.0
gopkg.in/inf.v0 v0.9.1
)
-go 1.13
+require (
+ github.com/bitly/go-hostpool v0.0.0-20171023180738-a3a6125de932 //
indirect
+ github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869 //
indirect
+ github.com/davecgh/go-spew v1.1.1 // indirect
+ github.com/kr/pretty v0.1.0 // indirect
+ github.com/pierrec/lz4/v4 v4.1.8 // indirect
+ github.com/pmezard/go-difflib v1.0.0 // indirect
+ gopkg.in/yaml.v3 v3.0.1 // indirect
+)
+
+replace github.com/gocql/gocql/lz4 => ./lz4
Review Comment:
When I was trying to run tests over lz4 pkg with changes I faced compilation
errors. It looks like go uses vendored `cassandra-gocql-driver/lz4` instead of
local, so I decided to add this. There is PR #1842 that moves `lz4` to `gocql`
module. If it is merged first, It will enable me to remove this `replace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
