belliottsmith commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1993184472
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -140,6 +140,7 @@ private SchemaKeyspace()
+ "clustering_order text,"
+ "column_name_bytes blob,"
+ "kind text,"
+ + "unique_id int,"
Review Comment:
I think the main thing is that the uids are all assigned on the same version
of the metadata. I am not certain if it matters whether the cluster is all up
to date, except if not we would need to pull the latest metadata from CMS on
upgrade (but perhaps this isn't a bad policy anyway).
Perhaps it makes sense to have an "upgraded" epoch, that is issued by CMS to
allocate these ids. So we don't allocate the initial ones under any other
circumstance (and only allocate additional ids once the initial ones have been
allocated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
