belliottsmith commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1993539458
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -140,6 +140,7 @@ private SchemaKeyspace()
+ "clustering_order text,"
+ "column_name_bytes blob,"
+ "kind text,"
+ + "unique_id int,"
Review Comment:
That is how it works, it's just done in `TableMetadata.Builder.build()`
since this can guarantee to make the same decision regardless of `addColumn`
order, and importantly can guarantee to know the existing uids to derive the
decision.
Ok, so it sounds like this is all fine so long as we _don't_ do this for
existing `TableMetadata` until this listener fires...? Not 100% sure how best
to do that, but we can perhaps revisit this in a dedicated ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
