dcapwell commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1991863925
##########
src/java/org/apache/cassandra/service/accord/serializers/AwaitSerializers.java:
##########
@@ -114,8 +114,8 @@ public long serializedSize(A await, int version)
}
};
- public static final IVersionedSerializer<AwaitOk> syncReply = new
EnumSerializer<>(AwaitOk.class);
- public static final IVersionedSerializer<RecoverAwaitOk> recoverReply =
new EnumSerializer<>(RecoverAwaitOk.class);
+ public static final IVersionedSerializer<AwaitOk> syncReply =
EncodeAsVInt32.of(AwaitOk.class);
+ public static final IVersionedSerializer<RecoverAwaitOk> recoverReply =
EncodeAsVInt32.of(RecoverAwaitOk.class);
Review Comment:
reviewing this as it conflicts with
https://github.com/apache/cassandra/pull/3954/
why this change? im am not against it, just trying to understand the
motivations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
