beobal commented on code in PR #3967:
URL: https://github.com/apache/cassandra/pull/3967#discussion_r1993500315


##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -140,6 +140,7 @@ private SchemaKeyspace()
               + "clustering_order text,"
               + "column_name_bytes blob,"
               + "kind text,"
+              + "unique_id int,"

Review Comment:
   The only way to witness some epoch without witnessing preceding epochs  is 
to have caught up via a snapshot of some state inbetween (so it's not possible 
with consecutive epochs like this). 
   After (in epoch terms) the uid-assigning feature has been activated, then 
the transform in your epoch 2 which performs an alter table to add v3 will 
assign uids. In order for any node to witness the transform in your epoch 3 
which adds v2, it must also have either witnessed epoch 2 *or* a snapshot 
containing the effects of epoch 2 (i.e. it will know about v3, and as the uids 
are part of TableMetadata it will know about them as well).    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to