dcapwell commented on code in PR #4006:
URL: https://github.com/apache/cassandra/pull/4006#discussion_r2010855240
##########
src/java/org/apache/cassandra/service/paxos/Paxos.java:
##########
@@ -1111,7 +1111,12 @@ private static BeginResult begin(long deadline,
PaxosPrepare.Success success = prepare.success();
Supplier<Participants> plan = () -> success.participants;
- DataResolver<?, ?> resolver = new DataResolver<>(query,
plan, NoopReadRepair.instance, new
Dispatcher.RequestTime(query.creationTimeNanos()));
+ long createdAtNanos = query.creationTimeNanos();
Review Comment:
bug found when enabling v2 testing. v2 would trigger ShortReadProtection
which defines the timeout based off a `deadline` which we compute based off the
value published to `Dispatcher.RequestTime`, the issue is that this request
doesn't have its time set, so we get `-1` which breaks the timeout!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
