aweisberg commented on code in PR #4006:
URL: https://github.com/apache/cassandra/pull/4006#discussion_r2019171238


##########
test/unit/org/apache/cassandra/cql3/ast/AssignmentOperator.java:
##########
@@ -59,10 +59,15 @@ public static EnumSet<Kind> 
supportsOperators(AbstractType<?> type, boolean isTr
         EnumSet<Kind> result = EnumSet.noneOf(Kind.class);
         if (type instanceof CollectionType && type.isMultiCell())
         {
-            if (type instanceof SetType || type instanceof ListType)
+            if (type instanceof SetType)
                 return EnumSet.of(Kind.ADD, Kind.SUBTRACT);
+            if (type instanceof ListType)

Review Comment:
   Huh, does the Accord translation of non-SERIAL reads handle this correctly 
by pushing it into the transaction? I don't think it does because this is 
solved for CAS only I think. I mean I guess it's non-SERIAL so it's fine for it 
not to be linearizable since we aren't committed to promising linearizability 
for non-SERIAL, but it will be a barrier to improving later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to