dcapwell commented on code in PR #4006:
URL: https://github.com/apache/cassandra/pull/4006#discussion_r2017707724
##########
test/unit/org/apache/cassandra/cql3/ast/AssignmentOperator.java:
##########
@@ -59,10 +59,15 @@ public static EnumSet<Kind>
supportsOperators(AbstractType<?> type, boolean isTr
EnumSet<Kind> result = EnumSet.noneOf(Kind.class);
if (type instanceof CollectionType && type.isMultiCell())
{
- if (type instanceof SetType || type instanceof ListType)
+ if (type instanceof SetType)
return EnumSet.of(Kind.ADD, Kind.SUBTRACT);
+ if (type instanceof ListType)
Review Comment:
List's `-=` does a read before write to know how to delete, and this does
the read at the CL that the write is done at. In these tests multi node
clusters tend to do `NODE_LOCAL` for writes and `ALL` for reads (more to stress
reads and to lower the non-deterministic behavior). Given this, only
transactional queries (CAS/Accord) are safe to add `-=`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
