belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2175620842
##########
accord-core/src/main/java/accord/local/Bootstrap.java:
##########
@@ -146,7 +146,13 @@ void start(SafeCommandStore safeStore)
.flatMap(syncPoint -> node.withEpochAtLeast(epoch, null,
() -> store.build(empty(), safeStore1 -> {
if (valid.isEmpty()) // we've lost ownership of the
range
return AsyncResults.success(Ranges.EMPTY);
- return fetch = safeStore1.dataStore().fetch(node,
safeStore1, valid, syncPoint, this);
+ if (kind == Kind.Sync)
+ return fetch = safeStore1.dataStore().sync(node,
safeStore1, valid, syncPoint, this);
Review Comment:
maybe pass this parameter to `fetch` rather than having two methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
