belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2184729131
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -699,6 +699,15 @@ protected boolean shouldBootstrap(Node node, Topology
local, Topology newLocalTo
return newLocalTopology.epoch() != 1;
}
+ public AsyncChain<?> rebootstrap(Node node)
+ {
+ List<AsyncChain<?>> results = new ArrayList<>();
+ Snapshot snapshot = current;
+ for (ShardHolder shard : snapshot.shards)
+ results.add(shard.store.rebootstrap(node,
shard.ranges.currentRanges(), snapshot.global.epoch()));
Review Comment:
FWIW, we also need a parameter (*somewhere*) that tells the CommandStore
we're rebootstrapping _due to corruption_ (or loss of data). This should
_reset_ RedundantBefore, because we don't know what parts of the log we know
our prior responses/decisions for locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
