ifesdjeen commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2176497984
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -699,6 +699,15 @@ protected boolean shouldBootstrap(Node node, Topology
local, Topology newLocalTo
return newLocalTopology.epoch() != 1;
}
+ public AsyncChain<?> rebootstrap(Node node)
+ {
+ List<AsyncChain<?>> results = new ArrayList<>();
+ Snapshot snapshot = current;
+ for (ShardHolder shard : snapshot.shards)
+ results.add(shard.store.rebootstrap(node,
shard.ranges.currentRanges(), snapshot.global.epoch()));
Review Comment:
My understanding is that we always want to rebootstrap everything,
especially if we've been down for a while.
I can add an option to rebootstrap only a specific range, for example, if we
know that there was a single problem during replay, in which case I can grab
command store's ranges for the command that failed.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
