Maxwell-Guo commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2269948492
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -60,8 +60,8 @@ public final class CreateIndexStatement extends
AlterSchemaStatement
public static final String CUSTOM_MULTIPLE_COLUMNS = "Only CUSTOM indexes
support multiple columns";
public static final String DUPLICATE_TARGET_COLUMN = "Duplicate column
'%s' in index target list";
public static final String COLUMN_DOES_NOT_EXIST = "Column '%s' doesn't
exist";
- public static final String INVALID_CUSTOM_INDEX_TARGET = "Column '%s' is
longer than the permissible name length of %d characters or" +
- " contains
non-alphanumeric-underscore characters";
+ public static final String INVALID_CHARS_CUSTOM_INDEX_TARGET = "Column
'%s' contains non-alphanumeric-underscore characters";
Review Comment:
There should be some relationship between the variable name and the variable
content，But the name is INVALID_CHARS_CUSTOM_INDEX_TARGET and the content is
column contains non-alphanumeric-underscore,
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -229,8 +237,9 @@ private void validateIndexTarget(TableMetadata table,
IndexMetadata.Kind kind, I
AbstractType<?> baseType = column.type.unwrap();
- if ((kind == IndexMetadata.Kind.CUSTOM) &&
!SchemaConstants.isValidName(target.column.toString()))
- throw ire(INVALID_CUSTOM_INDEX_TARGET, target.column,
SchemaConstants.NAME_LENGTH);
+ // This check will be removed with CASSANDRA-20235
Review Comment:
remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
