k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2270048433
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -229,8 +237,9 @@ private void validateIndexTarget(TableMetadata table,
IndexMetadata.Kind kind, I
AbstractType<?> baseType = column.type.unwrap();
- if ((kind == IndexMetadata.Kind.CUSTOM) &&
!SchemaConstants.isValidName(target.column.toString()))
- throw ire(INVALID_CUSTOM_INDEX_TARGET, target.column,
SchemaConstants.NAME_LENGTH);
+ // This check will be removed with CASSANDRA-20235
Review Comment:
This line is put on purpose as such check must not exist. It indicates that
fixing it is left to a follow up work. Can you explain your reasoning for your
comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
