k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2270039865
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -60,8 +60,8 @@ public final class CreateIndexStatement extends
AlterSchemaStatement
public static final String CUSTOM_MULTIPLE_COLUMNS = "Only CUSTOM indexes
support multiple columns";
public static final String DUPLICATE_TARGET_COLUMN = "Duplicate column
'%s' in index target list";
public static final String COLUMN_DOES_NOT_EXIST = "Column '%s' doesn't
exist";
- public static final String INVALID_CUSTOM_INDEX_TARGET = "Column '%s' is
longer than the permissible name length of %d characters or" +
- " contains
non-alphanumeric-underscore characters";
+ public static final String INVALID_CHARS_CUSTOM_INDEX_TARGET = "Column
'%s' contains non-alphanumeric-underscore characters";
Review Comment:
I am not sure what you are trying to say. There is clear relationship as in
the original constant. The error message is to be used for a customer index
target as in the original variable and the error is about invalid characters. I
don't see need to be more verbose in the constant and explain which chars are
invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
