isaacreath commented on code in PR #264:
URL: https://github.com/apache/cassandra-sidecar/pull/264#discussion_r2478416594
##########
server/src/main/java/org/apache/cassandra/sidecar/CassandraSidecarDaemon.java:
##########
@@ -73,12 +73,12 @@ static boolean close(Server app)
app.close()
.toCompletionStage()
.toCompletableFuture()
- .get(1, TimeUnit.MINUTES);
+ .get(2, TimeUnit.MINUTES);
Review Comment:
I noticed in CI that sometimes it would take sidecar more than 1 minute to
exit which would cause test failures (even outside of this branch). I suppose
we could look into this further so that we do not need to increase this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
