isaacreath commented on code in PR #264:
URL: https://github.com/apache/cassandra-sidecar/pull/264#discussion_r2514683476
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/CassandraAdapterDelegate.java:
##########
@@ -242,7 +251,7 @@ protected synchronized void jmxHealthCheck()
/**
* Performs health checks by utilizing the native protocol
*/
- protected void nativeProtocolHealthCheck()
+ protected synchronized void nativeProtocolHealthCheck()
Review Comment:
The goal was to ensure that we're explicitly guarding the modification to
`nodeSettingsFromCql` in case we have other callers of this function in the
future, but I think it's fine that we are guarding this through the
`isHealthCheckActive` compare and set in `healthCheck()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
