isaacreath commented on code in PR #264:
URL: https://github.com/apache/cassandra-sidecar/pull/264#discussion_r2478792661
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/BasicPermissions.java:
##########
@@ -88,4 +88,8 @@ public class BasicPermissions
// Lifecycle permissions
public static final Permission READ_LIFECYCLE = new
DomainAwarePermission("LIFECYCLE:READ", CLUSTER_SCOPE);
public static final Permission MODIFY_LIFECYCLE = new
DomainAwarePermission("LIFECYCLE:MODIFY", CLUSTER_SCOPE);
+
+ // Cassandra Settings Permissions
+ // Caller must have been granted SELECT on `system_view.settings` to hit
the /api/v2/cassandra/settings API.
+ public static final Permission READ_SETTINGS = new
StandardPermission("SELECT", TABLE_SCOPE);
Review Comment:
Addressed in
https://github.com/apache/cassandra-sidecar/pull/264/commits/bbb94f7972d10813a3f7ebb1bde3a10dd1fed8ad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]