minal-kyada commented on PR #4556: URL: https://github.com/apache/cassandra/pull/4556#issuecomment-4002666484
> sorry for the delay, here is another set of comments > > We have to rate limit the write warnings - they are quite different from the read warnings because the writes are quick even if the partition is wide and enabling this could be bad for some users. I ran a few benchmarks and latency tripled when sending warnings. Initially we could just rate limit `CoordinatorWarnings.processWarnings` but at some point (probably followup ticket) we should flag the mutation messages with a `trackWarnings` flag which tells replicas if they should add the warnings, to avoid them doing unnecessary work. > > We should also probably file followup tickets to make the warnings more detailed, we shouldn't send a warning if a user is doing DELETEs on a wide partition for example (that is a good thing), or writing to one with many tombstones. These are some interesting findings @krummas, curious to know how you ran the benchmarks, will add the rate limiter for now and address the other 2 important things as a follow up PR to this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
