krummas commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2895057822
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -585,6 +585,7 @@ public static class SSTableConfig
public volatile boolean write_thresholds_enabled = false;
public volatile DataStorageSpec.LongBytesBound write_size_warn_threshold =
null;
+ public volatile long coordinator_write_warn_interval_ms = 1000;
Review Comment:
this should be a `DurationSpec.LongMillisecondsBound` (and remove the `_ms`
suffix)
##########
src/java/org/apache/cassandra/service/writes/thresholds/CoordinatorWriteWarnings.java:
##########
@@ -93,6 +109,9 @@ public static void reset()
private static void processWarnings(Warnings warnings)
{
+ if (!timeForWarn())
Review Comment:
I think this should be after the if statement below (or probably as the last
check in that `if`), otherwise we might update `nextWarn` but not have any
warnings to send
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
