minal-kyada commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2896894582
##########
src/java/org/apache/cassandra/service/writes/thresholds/CoordinatorWriteWarnings.java:
##########
@@ -93,6 +109,9 @@ public static void reset()
private static void processWarnings(Warnings warnings)
{
+ if (!timeForWarn())
Review Comment:
I thought of it the other way, we might go through all the check and later
figure out that nextWarn doesn't qualify and all the efforts to check for
warnings is waste. It is cheap, but it has a side effect: it updates nextWarn
via compareAndSet. If it succeeds, the next call within the interval will be
rejected. Hence have it post warnings check makes sense. I will push this check
below warning check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
