Aklakan commented on PR #2395: URL: https://github.com/apache/jena/pull/2395#issuecomment-2058504184
test_cancel_select_1 does not raise the exception because the iterator is not accessed - the cancel flag is set though. IMO QueryCancelledException should only be thrown on iterator access - if it were raised directly on `select()` then in general one would need two exception handlers - one on the iterator and one on the query exec level. The try-with-resources block closes resources of a query exec whose iterator has not been touched - so there is shouldn't be a resource leak. I have so far only looked at the select case (not construct, describe, etc) - should I look into this and extend the PR or will you work on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
