Aklakan commented on PR #2395: URL: https://github.com/apache/jena/pull/2395#issuecomment-2068029396
> I'm personally in favour of consistency (my perceived idea of consistency!) which is fail ASAP. Right, I agree that fail fast is typically easier to debug. I noticed that `execute()` was only used for select and describe, whereas `startQueryIterator()` is the method actually common to all operations - so I moved the abort check there. I also extended your iterator-based test cases to make two assertions whether abort happens before or after obtaining the iterator. The test cases now work according to our understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
