afs commented on PR #2395: URL: https://github.com/apache/jena/pull/2395#issuecomment-2077253529
Looks good. I'll do some clearup - like not call a test class "... AFS". I've been looking at the Java memory model recently and there a volatile which could at least be an `AtomicReference` and maybe use fences, not full volatile semantics. It won't make an observable difference in this situation but it least the pattern will be recorded - not going as far as `VarHandles` which look quite complicated and fragile for general code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
