Aklakan commented on code in PR #3405:
URL: https://github.com/apache/jena/pull/3405#discussion_r2311853498


##########
jena-arq/src/main/java/org/apache/jena/sparql/util/XSDNumUtils.java:
##########
@@ -147,6 +147,18 @@ public static String 
canonicalDecimalStrNoIntegerDot(BigDecimal bd) {
         return bd.stripTrailingZeros().toPlainString();
     }
 
+    /** Return a canonical decimal with a trailing ".0". */
+    public static BigDecimal canonicalDecimalWithDot(BigDecimal decimal) {

Review Comment:
   This new method is used on input after parsing the lexical form into a 
decimal - just before inlining. The Str Version ist used on output, after 
converting the decimal to string. I think that the Str Version could be removed 
in favor of Decimal.toPlainString() since the binary representation is now 
canonicalized on input.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to