afs commented on code in PR #3405:
URL: https://github.com/apache/jena/pull/3405#discussion_r2312003069
##########
jena-tdb2/src/test/java/org/apache/jena/tdb2/store/value/TestNodeIdInline.java:
##########
@@ -120,6 +120,29 @@ public class TestNodeIdInline
@Test public void nodeId_decimal_8()
{ test("0.00000001", NodeFactory.createLiteralDT("0.00000001",
XSDDatatype.XSDdecimal)); }
+ @Test public void nodeId_decimal_9()
+ { test("'18'^^xsd:decimal",
+ NodeFactory.createLiteralDT("18.0", XSDDatatype.XSDdecimal));
+ }
+
+ @Test public void nodeId_decimal_10()
+ { test("'18.'^^xsd:decimal", NodeFactory.createLiteralDT("18.0",
XSDDatatype.XSDdecimal)); }
+
+ @Test public void nodeId_decimal_11()
+ { test("18.0", NodeFactory.createLiteralDT("18.0",
XSDDatatype.XSDdecimal)); }
+
+ @Test public void nodeId_decimal_20()
+ { testNodeIdRoundtrip(NodeValue.makeDecimal("18").asNode()); }
Review Comment:
Better to use `NodeFactory.createLiteralDT`, posisbly via a new
`testNodeIdRoundtripDecimal(String)`.
`NodeValue.makeDecimal` may have other effects; in fact, adding it into the
round triple steps might be a good thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
