afs commented on PR #3511: URL: https://github.com/apache/jena/pull/3511#issuecomment-4097251272
See [2026-03-20-AFS-SparqlAdapter.patch](https://github.com/user-attachments/files/26138157/2026-03-20-AFS-SparqlAdapter.patch) Key points: * Add switchable deferment to update. * Bug fix for QueryExec.dataset * Fixes javadoc and unused imports _`QueryExecApp`_ Is `QueryExecApp` still needed or is its use superceeded by SparqlAdter/provider? _`TestSparqlAdapterSystem`_ I tried running with deferred=false but all tests continue to pass. Please add some "deferred off" testing. This should cover update as well. _SparqlAdapterRegistry_ There is no "SparqlAdapter" so this can be renamed "SparqlAdapter" There is no class javadoc and for this class, some documentation would be very valuable. The flexibility this PR adds would benefit from a page on the website. _Other_ There are 2 "// XXX Unwrap Graph view over a DatasetGraph?" I think unwrapping here, in the general case, would be wrong. Some wrappers are query change execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
