Aklakan commented on PR #3511: URL: https://github.com/apache/jena/pull/3511#issuecomment-4126891220
I split `SparqlAdapter` into `QueryExecBuilderRegistry` and `UpdateExecBuilderRegistry` to match the existing engine design. The exec builders are one level above the engines: `QueryExecBuilderRegistry` — `QueryEngineRegistry` `QueryExecBuilderFactory` — `QueryEngineFactory` `UpdateExecBuilderRegistry` — `UpdateEngineRegistry` `UpdateExecBuilderFactory` — `UpdateEngineFactory` This PR's design now follows the already well-established pattern which has been stable for years (if this counts as any indicator for future proofness). So IMO the modified files of this PR now blend in naturally into the existing infrastructure. Sorry for the caused confusion and any extra work this caused/still causes. Any further commits from now on should be only formatting/javadoc. (We can still have a call about it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
