On Wed, Sep 1, 2010 at 1:48 PM, Maurits van Rees <[email protected]> wrote: > Op 01-09-10 21:13, Jon Stahl schreef: >> On Wed, Sep 1, 2010 at 1:29 AM, Maurits van Rees >> <[email protected]> wrote: >>> Op 31-08-10 09:19, Espen Moe-Nilssen schreef: >>>> Hi >>>> >>>> I copied some code from plone's templates, and I get error from the* >>>> &mdash:* >>>> This probably means that some of the standard views in plone doesnt >>>> validate (?) >>> >>> That could very well be. I see lots of errors when running xmllint over >>> templates in CMFPlone. >>> >>> In this particular case,— should be replaced by— >>> >>> For a list of characters, see for example >>> http://yost.com/computers/htmlchars/html40charsbynumber.html >> >> Maurits- >> >> Could you share the results of that report with plone-developers (if >> you haven't already), and perhaps write up any tips on avoiding common >> mistakes? This might help folks tackle the tweaks (I for example >> would be happy to make fixes, if I had a hot-sheet of bugs). :-) >> >> :jon > > The 'report' is just the result of running xmllint over some templates. > Here is some sample output: > > ============================================================ > mauritsvanr...@procyon:~/buildout/plone-coredev/4.0/src/Plone/Products/CMFPlone/skins/plone_content > $ xmllint --noout *pt > author.cpt:54: parser error : Entity 'nbsp' not defined > > ^ > author.cpt:80: parser error : Entity 'nbsp' not defined > <div class="contentActions"> </div> > ^ > author.cpt:116: parser error : Entity 'mdash' not defined > — > ^ > author.cpt:133: parser error : Entity 'hellip' not defined > nslate="label_author_internal_home_page">Author's home page in this > site… > ============================================================ > > > Some quick and dirty grepping in Products.CMFPlone tells me that the > most popular errors seem to be: > > - Entity 'hellip' not defined > > - Entity 'mdash' not defined > > - Entity 'nbsp' not defined > > From looking at > http://yost.com/computers/htmlchars/html40charsbynumber.html > these should be changed as follows: > > - … -> … > > - — -> — > > - ->   > > > Note that I am no xmllint or Chameleon expert. In fact, I have no idea > how the benchmarks are made that I saw that indicate that adding > Chameleon makes Plone about two times faster (if I remember correctly). > From the amount of errors that xmllint currently throws, I can only > guess that local changes were made. > > Note that yesterday I fixed the errors that xmllint indicated in > Products.Poi trunk. Here is the changeset, which may be instructive to > others: > http://dev.plone.org/collective/changeset/124651
Thanks, Maurits! This seems like the perfect Tune-Up task. I might also start chewing away on this, since it seems like the level of fixing I can handle without screwing up too bad. ;-) :jon _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
