#205: Fix Pylint errors
------------------------+---------------------------------------------------
  Reporter:  bthiell    |       Owner:  bthiell 
      Type:  defect     |      Status:  in_merge
  Priority:  major      |   Milestone:          
 Component:  *general*  |     Version:          
Resolution:             |    Keywords:          
------------------------+---------------------------------------------------

Comment (by simko):

 1) The following bibconvert.py change seem like something we should
 triple-verify, because BibConvert is used by WebSubmit: (can be done
 after merge)

 {{{
 -                out = re.sub(par[0], value)
 +                out = re.sub(par[0], par[1], value)
 }}}

 2) `dico_collection_external_searches` and friends used to be module
 variables, but were commented by 876e049c6754359a66c0bdb7f6c2dd0c5ccae66e.
 This patch enables them again, so please double check dict loading part.

 3) WRT search_engine import splitting, at some places it was necessary
 to avoid circular import problem.  This is probably not an issue for
 this very branch, but please check if all unit/regression/web tests
 are working fine as before the branch.

 4) If you have time, let's attack also the pylint-commenting of all the
 WebSubmit false positives :)

-- 
Ticket URL: <http://invenio-software.org/ticket/205#comment:4>
Invenio <http://invenio-software.org>

Reply via email to