#205: Fix Pylint errors
------------------------+---------------------------------------------------
Reporter: bthiell | Owner: bthiell
Type: defect | Status: assigned
Priority: major | Milestone:
Component: *general* | Version:
Resolution: | Keywords:
------------------------+---------------------------------------------------
Changes (by simko):
* status: in_merge => assigned
Comment:
Thanks for checking the issues I mentioned. Some more observations:
5) I see that you have also added in the meantime a patch for
`search_unit_in_bibrec()` in 0f0215ee6f3bbae6806f8cb678d3791d2e022b81,
but it seems to break the functionality in that you cannot search
anymore for `2010-01-10' to find the given day. (Yes, the wildcard
leads to a warning, but it is harmless.) I'll leave this one out
unless you have had some other motivation in mind?
6) I'll also leave out b7b0cf18f5a0682197331f64fb819fceef38610b since it
could mask deeper errors. (I don't think I have ever seen troubles
with getting the score in that way.)
7) After test-merging your branch and resolving some easy conflicts in
WebComment, there are some failing tests:
{{{
======================================================================
ERROR: bibconvert - LIMW(c,L)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/cds-invenio/lib/python/invenio/bibconvert_tests.py", line
139, in test_limw_left
bibconvert.FormatField(test_input, "LIMW(//[!_-]//,L)"))
File "/usr/lib/python2.6/dist-packages/invenio/bibconvert.py", line 993,
in FormatField
par[0] = re.search(par[0], value).group()
AttributeError: 'NoneType' object has no attribute 'group'
======================================================================
ERROR: bibconvert - LIMW(c,R)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/cds-invenio/lib/python/invenio/bibconvert_tests.py", line
149, in test_limw_right
bibconvert.FormatField(test_input, "LIMW(//[!_-]//,R)"))
File "/usr/lib/python2.6/dist-packages/invenio/bibconvert.py", line 993,
in FormatField
par[0] = re.search(par[0], value).group()
AttributeError: 'NoneType' object has no attribute 'group'
======================================================================
FAIL: bibconvert - formatting functions
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/cds-invenio/lib/python/invenio/bibconvert_tests.py", line 50,
in test_ff
self.assertEqual("Hello world!", bibconvert.FormatField("Hello
world!", "EXP(//[abcd]+//,1)"))
AssertionError: 'Hello world!' != 'Hello'
----------------------------------------------------------------------
}}}
I have not looked why. Do the tests work fine for you?
8) Also, there is this difference in behaviour of the regression test
suite:
{{{
-*** ERROR: Page
http://pcuds33.cern.ch/admin/bibedit/bibeditadmin.py/submit (login guest)
not accessible. HTTP Error 404: Not Found
+*** ERROR: Page
http://pcuds33.cern.ch/admin/bibedit/bibeditadmin.py/submit (login guest)
not accessible. HTTP Error 500: Internal Server Error
}}}
Probably not important, since we shall kill this part of the codebase
anyway, but it could perhaps mask something...
--
Ticket URL: <http://invenio-software.org/ticket/205#comment:10>
Invenio <http://invenio-software.org>
