2008/5/26 Ed <[EMAIL PROTECTED]>:
> 2008/5/26 John Darrington <[EMAIL PROTECTED]>:
>> This is overly complex.  You don't need these conditionals.  Instead of
>> #ifndef PSPP_WITH_GTK_2_10_0, you can simply use the GTK_CHECK_VERSION
>> macro.  See
>> http://library.gnome.org/devel/gtk/stable/gtk-Feature-Test-Macros.html

This wouldn't necessarily be an improvement.

1/ the AM_CONDITIONAL would still be needed

2/ both tests would still be needed to give the warnings (upgrade to
2.10, 2.12 for more functionality)

3/ this system (while cumbersome) forces you to recognise what
distinct versions you're offering functionality to. It reduces the
risk you'll add another version dependency somewhere in the code
without updating autoconf to know about it and offer the relevant
warnings and options.

Ed


_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev

Reply via email to