On Mar 4, 2011, at 8:25 AM, Markus Roberts <mar...@puppetlabs.com> wrote:
> > This would terminate the operating code inside puppet at that point; > > now logging is fatal, and there is no mechanism to suppress that. If > > it wasn't for that property I would pretty much entirely agree. > > Huh; not sure why it's a bad thing to terminate the processing here, since > then at least you get a stack trace and such, but I'll take your word for it > that it is. > Because sometimes we want to write a test that asserts that an error will be logged under certain circumstances, or that some condition is or isn't modified when a condition which results in a logged error occurs. Such tests would always either fail or pass for the wrong reasons. I thought processing would only stop if the log wasn't stubbed, in which case you've got a failure you didn't plan on. If you correctly stub/expect the logs, then processing should absolutely continue. Am I missing something? -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.