----- Original Message -----
> > > Also, if you are going to follow the per-compile pattern of module_dir > > > (which seems reasonable) you should also clear the thread var (see > > > lib/puppet/configurer.rb around line 160) so that it doesn't get > > > stale. > > > > this is good I was wondering about clearing it but really have no > > idea how this code works inside, this will cover both the agent and the > > master? Should I be clearing it in puppet/parser/compiler.rb line 25 too? > > Yes, but above the new() rather than in the ensure block (in other > words, make sure you're applying it on top of something with the fix > for #5318 (commit:68c106e3ef192) in it. Seems to be in master so should be safe, I am going to make these changes and resend the patch after this. > > > running the specs with an added > > Thread.current[:gemsearch_directories] = nil > > in both cases doesnt kill my machine like before or make more tests > > fail > > (lots of failing tests even before I started) so it seems sane to > > me. > > Hmmm. Lots of failing tests? That shouldn't be happening, as far as > I know. They all seem to fail 'Could not find a default provider for group' or similar. Am on CentOS -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
