On Mon, Jun 6, 2011 at 15:43, Daniel Pittman <dan...@puppetlabs.com> wrote: > On Mon, Jun 6, 2011 at 13:57, R.I.Pienaar <r...@devco.net> wrote: > >>> So, add that comment and I am happy to see this go in. Throw my >>> reviewed-by on the change and you can go ahead and merge it into >>> master. (I think you have the commit rights already, but if not I >>> will chase Zach to get them for you.) >>> >>> Thanks for writing this, and I think it is a great thing to have >>> added to the system. […] > For now, though, I will get that merged in the next few minutes.
Damn. So, I was going through the last little steps in testing this after I merged it locally, before pushing, and we ran into a set of concerns that we don't have time to address right now. Specifically, there are two concrete issues we are worried about here: One, we are concerned that there might be cases where this adds the gem path, but not everything on the Ruby $LOAD_PATH, to the locations our autoloader (or one of the other open-coded implementations of the same) hunt for things on disk. That should be easy enough to verify, but we want (someone) to audit that before this gets merged. Two, we are concerned that this potentially adds trouble when someone has two copies of Puppet installed, one through RubyGems, and the other through an OS package, or from source, or something like that. This introduces a new path that code can get loaded, and it isn't at all clear which will win from the outside. We have a cluster of other issues in the area, though: we need to be able to pluginsync faces and actions, as well as utility functions; we want to make sure we have consistent search paths to avoid the "face discovered, but can't be loaded" showing up in another guise, and that sort of thing. So, from discussion with Nigel and James we are going to hold this off for a bit: the code you have is correct, and ready to merge, and is going to stay there until we merge it as part of sorting out the rest of the mess around this area. So, sorry: I wish I had thought of this earlier, or could more easily convince myself (and Nigel) that this was a safe step toward the ultimate goal right now, rather than having to delay landing it. :/ I really want to see this feature in. Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <dan...@puppetlabs.com> ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
