On Monday, December 17, 2012 5:55:30 PM UTC+11, James Polley wrote: > > > I don't think so. > > http://semver.org/ is quite specific about this: you can increment the > patch version "if only backwards compatible bug fixes are introduced", the > minor version "if new, backwards compatible functionality is introduced to > the public API" - but "if any backwards incompatible changes are introduced > to the public API", "Major version X (X.y.z | X > 0) MUST be incremented" > > My reading is that, even if this is just a bugfix, the fact that it's > backwards-incompatible requires a major version bump. >
Well, without a documented API you could argue that all bugfixes are backwards-incompatible changes. A backwards incompatible change is a change to the public API, as you've noted. In this case the fact in question is apparently supposed to count logical CPUs whereas in reality it counts CPU cores on Solaris. Is there an actual documented API to refer to? If not, I don't think SemVer really helps us here - it becomes a matter of opinion as to what the implied API is. In my opinion, the implied API is that processorcount counts logical CPUs and currently gets it wrong on Solaris. All said, however, whatever SemVer says I think for purely practical reasons perhaps we should treat this as a backwards incompatible change. :) -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/puppet-dev/-/LzyGplMq3F0J. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
