----- Original Message ----- > From: "Erik Dalén" <erik.gustav.da...@gmail.com> > To: puppet-users@googlegroups.com > Sent: Thursday, June 28, 2012 9:42:43 AM > Subject: Re: [Puppet Users] Re: error after upgrading from > 2.7.14-2puppetlabs1 to 2.7.17-1puppetlabs1 > > On 28 June 2012 02:00, Jeff McCune <j...@puppetlabs.com> wrote: > > On Wed, Jun 27, 2012 at 3:36 PM, llow...@oreillyauto.com > >> I had originally thought that 3.X would be the change where it > >> went from > >> warning to error, but it looks like they pushed this out with > >> 2.7.17 for > >> whatever reason. > > > > It was never a deprecation warning as far as I can tell. 2.6.16 > > errors out, as does 2.6.7 and 2.6.12. 2.7.0 and 2.7.1 did error > > out. > > 2.7.3 didn't error out for whatever reason and this was the point > > we > > accidentally regressed to allowing hyphens in variable names. This > > allowance remained all the way through 2.7.14. In 2.7.16 we > > "fixed" > > it again to error out with hyphens in variable names. This > > remained > > in 2.7.17. > > > > So, I think the story is... Don't use hyphens in variable names > > (and > > class names). We accidentally allowed them from 2.7.3 through > > 2.7.14 > > but we've gone back to it being an error. > > > > But it is only dashes in variables that produce errors in 2.7.16+, > right? I know they are deprecated in class names as well, but they have > worked in them for the most part since 0.24.x releases at least > AFAIK. Ofc if they aren't allowed in variable names you shouldn't be able to > refer to variables in classes with dashes, like > $class-name::variable. > > We unfortunately still have some classes with dashes in the names but > no variables, so I want to know if it is safe to upgrade to 2.7.17?
It does unfortunately still allow - in class names, I think the fix for this was half baked as you couldn't access variables in those classes from outside of the class docs says: "Class names, module names, and the names of defined and custom resource types should be restricted to lowercase alphanumeric characters and underscores, and should begin with a lowercase letter; that is, they should match the expression [a-z][a-z0-9_]*. Although some names that violate these restrictions currently work, using them is not recommended." -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
