On Tue, 9 Jul 2013 18:21:52 -0400 Ashley Penney <ashley.pen...@puppetlabs.com> wrote:
> http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is > where you can grab the latest if you're willing to test it. > > If you have any feedback regarding the general design of the module > this is an excellent place to hash it out as we'll be out to improve > other modules with time. It looks really nice and clean! I would personally only have a few very minor nitpicks : * Shouldn't the placeholder files/README.markdown be removed? * Space between class name and parenthesis inconsistency : "class foo(..." vs. "class foo (..." * In the templates, this comment should use single quotes : # Managed by puppet class { "ntp": servers => [ ... ] } * In the el template, this variable isn't in the current scope : <% if @is_virtual == "false" -%> Add a new params variable for it, similar to $panic? * For "real" RHEL, the ntp server hostnames used will be "centos" instead of the original "rhel" ones. I'm not sure this is worth trying to fix, though. Great work on cleaning up the module! Matthias -- Matthias Saou ██ ██ ██ ██ Web: http://matthias.saou.eu/ ██████████████ Mail/XMPP: matth...@saou.eu ████ ██████ ████ ██████████████████████ GPG: 4096R/E755CC63 ██ ██████████████ ██ 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ 21A9 7A51 7B82 E755 CC63 ████ ████ -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
