> As long as we're touting tools or processes that we have experience > with, Google uses a combination of tools. One tool is similar to the > buildbots, running tests *after* stuff has been checked in. A feature > that buildbot is missing is that it tries to figure which checkin is > responsible for a particular failure, and mails both the author of > that change and the owner of the code (if different).
Buildbot does have a blame list. Mailing the developer failed so far because we didn't have email addresses of each developer. Now, with the python-committers list, Brett collected them, so such mailing would be possible. I'm not sure about mailing the owner of the code: we don't typically have owners of code, right? Would you consider it useful to support the case were we do have an owner? Such an ownership database would need to be maintained, as well, and typically, when we do have owners, the owner is also the committer. > Another tool that helps code quality tremendously is mandatory peer > reviews of all code before checkin. Call me biased because I wrote the > first version of the tool that most Googlers today use for peer > reviews (Collin Winter now runs that show) and also open-sourced a > similar tool (Rietveld, http://codereview.appspot.com) that works with > Subversion. But I didn't set the policy of mandatory pre-checkin peer > reviews -- Google had that policy for years before, and other tools > had already been written. So would you enforce that policy with tools, too? If so, what would the workflow look like? > Anyway, if we're going to change policies around submitting code, I > would much rather see peer review become a habit than adopt a tool > like PQM. The part where I'm skeptical about such a policy is that there might be a shortage of reviewers. What if a patch on Rietvield doesn't find a reviewer for a month or so? Many patches in the tracker sit there for years without any committer reviewing them. Regards, Martin _______________________________________________ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
