On 5/13/20 10:54 PM, Greg Ewing wrote: > On 14/05/20 8:55 am, Richard Damon wrote: >> On 5/13/20 2:03 PM, Rhodri James wrote: >>> >>> I'm sorry, but I think the correct response is to give them a spanking >>> in code review. I certainly wouldn't pass any code that actually >>> relied on assert doing anything. >>> >> My thought was he just needs to add that case to the unit tests. > > This person seems to be a new team member who doesn't have the > power to force the others to do anything against their will. > So suggestions like this aren't going to help him. > > Mind you, changing the language as he requests probably wouldn't > help him either, as the other developers would just refuse to > upgrade to this new version that breaks their code. > But normally getting a test case added to unit tests is easier that establishing policy. You file a bug report that code fails with the -O option, an and a unit test to reproduce. (Which would seem justifiable unless the spec actually says -O not supported). To remove the test, someone is likely going to need to go on record that -O is not supported, which if it isn't really the policy, they would likely be a bit hesitant to do.
-- Richard Damon _______________________________________________ Python-ideas mailing list -- python-ideas@python.org To unsubscribe send an email to python-ideas-le...@python.org https://mail.python.org/mailman3/lists/python-ideas.python.org/ Message archived at https://mail.python.org/archives/list/python-ideas@python.org/message/M5BY3OBO72T7K2CN7WUAK3UK7I76HZID/ Code of Conduct: http://python.org/psf/codeofconduct/
