On Tue, 2019-08-20 at 20:12 +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > While there are other places where these are still stored in memory, > > this is still one less key material area that can be sniffed with > > various side channel attacks > > > > > > > > (Many empty lines here) > > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > --- > > crypto/block-luks.c | 52 ++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 44 insertions(+), 8 deletions(-) > > Wouldn’t it make sense to introduce a dedicated function for this?
Absolutely. I was mostly focused on fixing all the cases first. I usually refactor such ugly code at the end, but this time I forgot to do so. Plus I need to pick a place where to put such function (it can be useful in any place in qemu), and first check if maybe glib already has such free+scrub function implemented somewhere. Best regards, Maxim Levitsky