On Tue, 2019-08-20 at 18:38 +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > * rename the write_func to create_write_func, > > and init_func to create_init_func > > this is preparation for other write_func that will > > be used to update the encryption keys. > > > > No functional changes > > > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > --- > > block/crypto.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > I’m not quite sure why you remove or add blank lines seemingly at random...
Basically to have consistent two space separation between all functions. A bit of OCD I confess :-) > > > diff --git a/block/crypto.c b/block/crypto.c > > index 8237424ae6..42a3f0898b 100644 > > --- a/block/crypto.c > > +++ b/block/crypto.c > > [...] > > > @@ -77,7 +76,7 @@ struct BlockCryptoCreateData { > > }; > > > > > > -static ssize_t block_crypto_write_func(QCryptoBlock *block, > > +static ssize_t block_crypto_create_write_func(QCryptoBlock *block, > > size_t offset, > > const uint8_t *buf, > > size_t buflen, > > Alignment should be kept at the opening parentheses. Opps. I am still trying to learn that rule. Fixed. > > But other than those two things, why not. > > Max > Best regards, Thanks for the review Maxim Levitsky