On Thu, 2019-08-22 at 16:34 +0200, Max Reitz wrote: > On 22.08.19 02:05, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 18:38 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > * rename the write_func to create_write_func, > > > > and init_func to create_init_func > > > > this is preparation for other write_func that will > > > > be used to update the encryption keys. > > > > > > > > No functional changes > > > > > > > > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> > > > > --- > > > > block/crypto.c | 15 ++++++++------- > > > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > > > > > > > I’m not quite sure why you remove or add blank lines seemingly at > > > random... > > > > Basically to have consistent two space separation between all functions. > > A bit of OCD I confess :-) > > Well, it didn’t work because in one place you added two empty lines > where we already had two, so there are four now. Exactly :-)
While the reason I sometimes add/remove black lines between functions is this, this time this was just a leftover from some stuff I removed and forget to remove the black lines. Usually prior to sending the patches I 'polish' very carefully such stuff, but this time since I send up the RFC, I didn't do that that well thus various issues like that poped up. Best regards, Maxim Levitsky