On Sun, Feb 4, 2024 at 9:36 AM David Hildenbrand <da...@redhat.com> wrote: > > On 04.02.24 02:35, Raphael Norwitz wrote: > > As a heads up, I've left Nutanix and updated it in MAINTAINERS. Will > > be updating it again shortly so tagging these with my new work email. > > > > Thanks for the fast review! The mail server already complained to me :) > > Maybe consider adding yourself as reviewer for vhost as well? (which > covers libvhost-user), I took your mail address from git history, not > get_maintainers.pl.
I don't expect I'll have much time to review code outside of vhost-user-blk/vhost-user-scsi, but happy to add an entry if it helps folks tag me on relevant patches. > > > On Fri, Feb 2, 2024 at 4:54 PM David Hildenbrand <da...@redhat.com> wrote: > >> > >> We barely had mmap_offset set in the past. With virtio-mem and > >> dynamic-memslots that will change. > >> > >> In vu_add_mem_reg() and vu_set_mem_table_exec_postcopy(), we are > >> performing pointer arithmetics, which is wrong. Let's simply > >> use dev_region->mmap_addr instead of "void *mmap_addr". > >> > >> Fixes: ec94c8e621de ("Support adding individual regions in libvhost-user") > >> Fixes: 9bb38019942c ("vhost+postcopy: Send address back to qemu") > >> Cc: Raphael Norwitz <raphael.norw...@nutanix.com> > >> Signed-off-by: David Hildenbrand <da...@redhat.com> > > > > Reviewed-by: Raphael Norwitz <raph...@enfabrica.net> > > > -- > Cheers, > > David / dhildenb >