On 2025/06/07 5:38, Paolo Bonzini wrote:
On Fri, Jun 6, 2025 at 11:46 AM Akihiko Odaki <akihiko.od...@daynix.com> wrote:
This conditional is unnecessary; docs/about/build-platforms.rst says we
only supports MinGW.
I failed to catch this problem because I ran MinGW on Windows, which is
case-insensitive. Since it is case-insensitive, the lowercase name will
work for the OS too.
Possibly, but better safe than sorry... The official name is the uppercase one.
There are already two libraries that are referenced with lowercase names
while they have uppercase characters in Windows SDK:
MinGW | Windows SDK
-------+------------
ws2_32 | WS2_32
winmm | WinMM
So there is no gain by trying out the name of the synchronization
library in Windows SDK; the build will break anyway if a build platform
requires case-sensitive matches with Windows SDK names.
I also think it's better to keep the library references consistent;
there is no reason to check the case-preserved name of a library while
not checking the one for another and vice versa. In this sense, we
should consistently check the case-preserved names or consistently avoid
checking them.
Regards,
Akihiko Odaki
