Il 05/06/2012 03:00, Michael Roth ha scritto:
> This will eventually be used to serialize device state for the purposes
> of migration/savevm, and is also useful for introspection/testing.
>
> Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
> ---
> hw/mc146818rtc.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index 7490d28..2dfc233 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -26,6 +26,7 @@
> #include "sysemu.h"
> #include "mc146818rtc.h"
> #include "mc146818rtc_state.h"
> +#include "qapi-generated/mc146818rtc-qapi-visit.h"
>
> #ifdef TARGET_I386
> #include "apic.h"
> @@ -590,6 +591,14 @@ static void rtc_get_date(Object *obj, Visitor *v, void
> *opaque,
> visit_end_struct(v, errp);
> }
>
> +static void rtc_get_state(Object *obj, Visitor *v, void *opaque,
> + const char *name, Error **errp)
> +{
> + ISADevice *isa = ISA_DEVICE(obj);
> + RTCState *s = DO_UPCAST(RTCState, dev, isa);
> + visit_type_RTCState(v, &s, name, errp);
> +}
> +
> static int rtc_initfn(ISADevice *dev)
> {
> RTCState *s = DO_UPCAST(RTCState, dev, dev);
> @@ -638,6 +647,9 @@ static int rtc_initfn(ISADevice *dev)
> object_property_add(OBJECT(s), "date", "struct tm",
> rtc_get_date, NULL, NULL, s, NULL);
>
> + object_property_add(OBJECT(s), "state", "RTCState",
> + rtc_get_state, NULL, NULL, s, NULL);
> +
> return 0;
> }
>
Nice! The next obvious step would be to use this from vmstate instead
of hardcoded struct offsets.
Paolo
