Am 05.06.2012 18:03, schrieb Michael Roth: > On Tue, Jun 05, 2012 at 11:29:24AM +0200, Kevin Wolf wrote: >> Am 05.06.2012 03:00, schrieb Michael Roth: >>> Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com> >>> --- >>> qidl-generated/mc146818rtc.json | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> create mode 100644 qidl-generated/mc146818rtc.json >> >> I haven't looked at the Makefiles, but does this commit mean that the >> files aren't generated automatically but you have to run the generator >> manually after changing any device struct? > > Nope, the files are automatically generated when changes are made to > QIDL sources and you do a build. > > The reason they're still checked-in is so that changes to a device's > serialization schema can be "signed-off" by the author that made the > change. This applies to qidl-generated vmstate descriptions as well.
Doesn't really make sense to me. You already have a sign-off for the changed header/source file. > It also makes an automated `make check-qidl` and, in the case of > qidl-generated vmstate descriptions, `make check-vmstate` possible, so > that a submitter/maintainer can detect and bring attention to changes to > serialized device state that need to be addressed/signed-off when > testing/reviewing patches. Why can't 'make check-qidl' generate the new version itself like a simple 'make' would do? > We could get part of the way there by just keeping tabs on changes to qidl > sources, but ultimately how we do the serialization is a matter of how the > generated visitors look, in which case the generated QAPI schemas are the more > reliable representation. Annotations are hints, schemas are ABI, so > tracking the latter is more important. So your statement is that the generator is likely buggy and therefore its output should be reviewed as well as the source changes? > Similar rationale for vmstate: the relationship between annotations and > the generated vmstate descriptions isn't strong enough that we can > easily infer changes based on qidl annotations, and in many cases those > inferred changes will be overwritten by special handling in the vmstate > generator. I don't understand. Is this file generated or manually edited? If the former, why does having it in the repository add anything new when you can (and with appropriate Makefile magic will) always run the generator after pulling changes to source files? If the latter, why does the subject say it's generated? Kevin
