Re: [PATCH v16 04/26] hw/arm: virt: add GICv2m for the case when ITS is not available

[Peter Maydell]

On Wed, 21 Jan 2026 at 12:00, Mohamed Mediouni <moha...@unpredictable.fr> wrote:
>
>
>
> > On 21. Jan 2026, at 12:33, Peter Maydell <peter.mayd...@linaro.org> wrote:
> >
> > which I think means we do need
> > the its option to be an on/off/auto one
>
> Hello,
>
> Would this be ok instead?
>
> typedef enum VirtMSIControllerType {
> VIRT_MSI_CTRL_NONE,
> /* This value is overriden at runtime.*/
> VIRT_MSI_CTRL_AUTO,
> /* Legacy option: its=off provides a GICv2m when using GICv2.*/
> VIRT_MSI_LEGACY_OPT_ITS_OFF,
> VIRT_MSI_CTRL_GICV2M,
> VIRT_MSI_CTRL_ITS,
> } VirtMSIControllerType;
>
> Combined with:
>
> static void finalize_msi_controller(VirtMachineState *vms)
> {
> if (vms->msi_controller == VIRT_MSI_LEGACY_OPT_ITS_OFF) {
> if (vms->gic_version == 2) {
> vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
> }
> else {
> vms->msi_controller = VIRT_MSI_CTRL_NONE;
> }
> }

Is this with the idea that the its option get/set
functions would set msi_controller (to ITS_OFF or ITS) ?

thanks
-- PMM