On Wed, 21 Jan 2026 at 12:27, Mohamed Mediouni <[email protected]> wrote: > > > > > On 21. Jan 2026, at 13:19, Peter Maydell <[email protected]> wrote: > > > > On Wed, 21 Jan 2026 at 12:00, Mohamed Mediouni <[email protected]> > > wrote: > >> > >> > >> > >>> On 21. Jan 2026, at 12:33, Peter Maydell <[email protected]> wrote: > >>> > >>> which I think means we do need > >>> the its option to be an on/off/auto one > >> > >> Hello, > >> > >> Would this be ok instead? > >> > >> typedef enum VirtMSIControllerType { > >> VIRT_MSI_CTRL_NONE, > >> /* This value is overriden at runtime.*/ > >> VIRT_MSI_CTRL_AUTO, > >> /* Legacy option: its=off provides a GICv2m when using GICv2.*/ > >> VIRT_MSI_LEGACY_OPT_ITS_OFF, > >> VIRT_MSI_CTRL_GICV2M, > >> VIRT_MSI_CTRL_ITS, > >> } VirtMSIControllerType; > >> > >> Combined with: > >> > >> static void finalize_msi_controller(VirtMachineState *vms) > >> { > >> if (vms->msi_controller == VIRT_MSI_LEGACY_OPT_ITS_OFF) { > >> if (vms->gic_version == 2) { > >> vms->msi_controller = VIRT_MSI_CTRL_GICV2M; > >> } > >> else { > >> vms->msi_controller = VIRT_MSI_CTRL_NONE; > >> } > >> } > > > > Is this with the idea that the its option get/set > > functions would set msi_controller (to ITS_OFF or ITS) ? > > > Yes, vms->its is completely gone in my tree.
That sounds like a good cleanup -- I was hoping to get rid of vms->its but didn't quite see the way to doing it. > Going to post a rev with it soon, would you prefer to have > it separate instead of a whole WHPX series? If these cleanup patches are at the start of the series you might as well post the whole lot with the WHPX patches. thanks -- PMM
