Re: [PATCH v16 04/26] hw/arm: virt: add GICv2m for the case when ITS is not available

[Mohamed Mediouni]

> On 21. Jan 2026, at 13:19, Peter Maydell <peter.mayd...@linaro.org> wrote:
> 
> On Wed, 21 Jan 2026 at 12:00, Mohamed Mediouni <moha...@unpredictable.fr> 
> wrote:
>> 
>> 
>> 
>>> On 21. Jan 2026, at 12:33, Peter Maydell <peter.mayd...@linaro.org> wrote:
>>> 
>>> which I think means we do need
>>> the its option to be an on/off/auto one
>> 
>> Hello,
>> 
>> Would this be ok instead?
>> 
>> typedef enum VirtMSIControllerType {
>> VIRT_MSI_CTRL_NONE,
>> /* This value is overriden at runtime.*/
>> VIRT_MSI_CTRL_AUTO,
>> /* Legacy option: its=off provides a GICv2m when using GICv2.*/
>> VIRT_MSI_LEGACY_OPT_ITS_OFF,
>> VIRT_MSI_CTRL_GICV2M,
>> VIRT_MSI_CTRL_ITS,
>> } VirtMSIControllerType;
>> 
>> Combined with:
>> 
>> static void finalize_msi_controller(VirtMachineState *vms)
>> {
>> if (vms->msi_controller == VIRT_MSI_LEGACY_OPT_ITS_OFF) {
>> if (vms->gic_version == 2) {
>> vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
>> }
>> else {
>> vms->msi_controller = VIRT_MSI_CTRL_NONE;
>> }
>> }
> 
> Is this with the idea that the its option get/set
> functions would set msi_controller (to ITS_OFF or ITS) ?
> 
Yes, vms->its is completely gone in my tree.

Going to post a rev with it soon, would you prefer to have it separate instead 
of a whole WHPX series?
> thanks
> -- PMM